Skip to content

[main] Update dependencies from dotnet/runtime #44751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 11, 2024
Merged

[main] Update dependencies from dotnet/runtime #44751

merged 15 commits into from
Nov 11, 2024

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 8, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241110.2
  • Date Produced: November 10, 2024 3:12:18 PM UTC
  • Commit: 80cb4583c9079cf052e6148b51b43590771b4353
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
e42e62b 
…1108.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24558.1
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Nov 8, 2024
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet dotnet deleted a comment from azure-pipelines bot Nov 8, 2024
@akoeplinger
Copy link
Member

akoeplinger commented Nov 8, 2024 •
edited
Loading

two ILLink tests fail due to:

Test output contained the following extra linker warnings:

  • ILLink : Trim analysis warning IL2045: Internal.Runtime.InteropServices.ComActivator.BasicClassFactory.CreateValidatedInterfaceType(Type, Guid&, Object): Attribute 'System.Runtime.InteropServices.ClassInterfaceAttribute' is being referenced in code but the trimmer was instructed to remove all instances of this attribute. If the attribute instances are necessary make sure to either remove the trimmer attribute XML portion which removes the attribute instances, or override the removal by using the trimmer XML descriptor to keep the attribute type (which in turn keeps all of its instances). [C:\h\w\991C091E\t\dotnetSdkTests\svxpipfk.y4v\ILLink_verify---936B265C\AnalysisWarningsOnHelloWorldApp\AnalysisWarningsOnHelloWorldApp.csproj]

Related to dotnet/runtime#109616 /cc @AaronRobinsonMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT requested a review from a team as a code owner November 8, 2024 18:52
@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Nov 8, 2024 •
edited
Loading

/cc @sbomer @agocke

sbomer
sbomer approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fix LGTM to unblock flow, though it would be better to annotate the place where the attribute lookup is done in COM, as discussed. (Just to improve the warning experience for the unsupported scenario where COM support is turned on.)

@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Nov 8, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Nov 8, 2024
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
d17cf12 
…1108.9

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24558.9
@build-analysis build-analysis bot mentioned this pull request Nov 9, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
39f3c2a 
…1109.3

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24559.3
@am11
Copy link
Member

am11 commented Nov 9, 2024

src/SourceBuild/patches/runtime/0001-Runtime patch to support net10.0.patch is failing to apply because dotnet/runtime#109634 was included. It's safe to delete this patch.

@akoeplinger akoeplinger requested review from a team as code owners November 9, 2024 22:29
@akoeplinger akoeplinger mentioned this pull request Nov 9, 2024
Merged
@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 10, 2024

@jkoritzinsky PTAL (unified build runtime errors) cpio not found

@am11
Copy link
Member

am11 commented Nov 10, 2024

I'm not 100% sure but I hope dotnet/arcade#15233 will resolve the cpio errors. Lets see. :)

@akoeplinger
Copy link
Member

akoeplinger commented Nov 10, 2024

We just missed it in the ubuntu image: dotnet/dotnet-buildtools-prereqs-docker#1253

dotnet-maestro bot and others added 2 commits November 10, 2024 13:42
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
e7bd41e 
…1110.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24560.1
@akoeplinger
Add more expected warnings, we need one entry for each warning instance
b4431fa
@akoeplinger
Copy link
Member

akoeplinger commented Nov 11, 2024

the sdk-source-build job now fails because we're passing the non-portable RID into the CreateRpmPackage task:
image

@am11
Copy link
Member

am11 commented Nov 11, 2024

Why https://github.com/dotnet/runtime/blob/35d27803b83bbd46d3cfe42aa58f46f585c0c6ae/src/installer/pkg/sfx/installers/dotnet-runtime-deps/Directory.Build.props#L7 isn't workng?
As a quick workaround, we could just pass -p:InstallerRuntimeIdentifier=linux-x64 from the vmr yml to get by and investigate it separately.

@akoeplinger
Copy link
Member

akoeplinger commented Nov 11, 2024

@am11 this is building src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj so that Directory.Build.props doesn't apply

@am11
Copy link
Member

am11 commented Nov 11, 2024

Right, we need to use the same InstallerRuntimeIdentifier=linux-{arch} there as well. You can pass it to runtime BuildArgs in this repo to unblock this PR (assuming this is the only thing blocking the flow).

@akoeplinger akoeplinger mentioned this pull request Nov 11, 2024
Closed
@akoeplinger
Copy link
Member

akoeplinger commented Nov 11, 2024

I've added the workaround and filed dotnet/source-build#4728, I think overriding in the runtime build is not the best long term fix since all this is really used for in the end is to decide whether to write linux or freebsd into the rpm: https://github.com/dotnet/arcade/blob/232061b49ae2157efbb83acde9acae79ef3d6d40/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs#L98

am11
am11 reviewed Nov 11, 2024
View reviewed changes
akoeplinger and others added 3 commits November 11, 2024 14:25
@akoeplinger
Fix workaround
098a495
@akoeplinger
Fix patch
c721ce7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
547c18b 
…1110.2

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24560.2
@premun premun mentioned this pull request Nov 11, 2024
Closed
@dotnet-maestro dotnet-maestro bot merged commit 20fd01c into main Nov 11, 2024
41 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-83161337-3bf7-43a8-9016-55cab8098606 branch November 11, 2024 18:35
@premun premun mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbomer sbomer sbomer approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer left review comments

@MichaelSimons MichaelSimons MichaelSimons left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@akoeplinger @AaronRobinsonMSFT @am11 @ViktorHofer @sbomer @MichaelSimons @premun